Skip to content

Conversation

@jgallagher
Copy link
Contributor

This isn't totally risk-free - it also pulls in a bump to tokio. But I think in general we want to track the latest tokio anyway?

Primary motivator for this is to pick up oxidecomputer/management-gateway-service#472, since @askfongjojo had a failed mupdate yesterday that should be fixed by that.

@jgallagher jgallagher requested review from hawkw and labbott November 25, 2025 16:31
checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c"
dependencies = [
"lazy_static",
"windows-sys 0.59.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downgrade, is that what we want? I had to manually fix this up last time too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what's happening with these. It shows up if I do this on main:

omicron (main %=)]% cargo update -p [email protected]
    Updating crates.io index
     Locking 1 package to latest Rust 1.89.0 compatible version
    Updating socket2 v0.6.0 -> v0.6.1

Maybe related to the "Locking 1 package to latest Rust 1.89.0 compatible version"?

I'm tempted to say "this is a windows crate which is totally irrelevant, so it's probably not worth doing work to worry about it and it's fine to let cargo update do whatever it does". But it would be nice to understand..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is rust-lang/cargo#5529. I can either manually patch this up, or just leave it alone (my preference since this is a crate we don't use in practice).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with leaving it alone if others are comfortable, especially since the downgrades are things we don't care about

checksum = "4979f22fdb869068da03c9f7528f8297c6fd2606bc3a4affe42e6a823fdb8da4"
dependencies = [
"cfg-if",
"windows-targets 0.52.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another downgrade

Copy link
Contributor

@labbott labbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might submit a tufaceous PR sometime just to bring everything to the same hubtools version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants